fix(nervous-system): release runscript doesn't prompt you to update mainnet-canisters.json #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
anchpop
changed the base branch from
master
to
@anchpop/runscript-schedule-vote
anchpop
force-pushed
the
@anchpop/runscript-schedule-vote
branch
from
0056a01 to
9ceb751
Compare
anchpop
force-pushed
the
@anchpop/no-need-to-manually-update-mainnet-json
branch
from
857f306 to
72d3d6b
Compare
anchpop
force-pushed
the
@anchpop/no-need-to-manually-update-mainnet-json
branch
from
72d3d6b to
f724821
Compare
anchpop
force-pushed
the
@anchpop/runscript-schedule-vote
branch
from
9ceb751 to
e7b889a
Compare
anchpop
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
max-dfinity
approved these changes
Feb 5, 2025
…update mainnet-canisters.json since it's done automatically now
anchpop
force-pushed
the
@anchpop/no-need-to-manually-update-mainnet-json
branch
from
f724821 to
28dad40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release runscript doesn't need to prompt you to update mainnet-canisters.json since PRs to do so are created automatically now, for example in #3727. We still need to remember to merge the automatically-created PR, but hopefully that will be pretty easy
← Previous PR | Next PR →