-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for enforcement of approval policy in deployment and configuration change #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshankvaish
force-pushed
the
feat/approval-policy
branch
from
December 2, 2024 11:59
b0d9b4c
to
92fe1dc
Compare
github-actions
bot
added
PR:Ready-to-Review
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
PR:Issue-verification-failed
labels
Dec 11, 2024
…ard into fix/approval-policy
fix: migrate to use isApprovalPolicyApplicable
AbhishekA1509
previously approved these changes
Dec 13, 2024
src/Pages/Applications/DevtronApps/Details/AppConfigurations/appConfig.scss
Outdated
Show resolved
Hide resolved
vivek-devtron
previously approved these changes
Dec 24, 2024
Quality Gate failedFailed conditions |
vivek-devtron
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1131
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: