refactor: remove redundant code

devtron-labs · Dec 2, 2024 · 92fe1dc · 92fe1dc
1 parent 13b094e
commit 92fe1dc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/components/app/details/appDetails/SourceInfo.tsx b/src/components/app/details/appDetails/SourceInfo.tsx
@@ -123,7 +123,7 @@ export const SourceInfo = ({
 
     const renderDevtronAppsEnvironmentSelector = (environment) => {
         // If moving to a component then move getIsApprovalConfigured with it as well with memoization.
-        const isApprovalConfigured = getIsApprovalPolicyConfigured(appDetails?.userApprovalMetadata?.approvalConfigData)
+        const isApprovalConfigured = getIsApprovalPolicyConfigured(appDetails?.approvalConfigData)
         const relativeSnapshotTime = appDetails?.resourceTree?.lastSnapshotTime
             ? handleUTCTime(appDetails.resourceTree.lastSnapshotTime, true)
             : ''

diff --git a/src/components/app/types.ts b/src/components/app/types.ts
@@ -28,7 +28,7 @@ import {
     RuntimeParamsListItemType,
     RuntimeParamsTriggerPayloadType,
     HelmReleaseStatus,
-    UserApprovalMetadataType,
+    ApprovalConfigDataType,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { DeploymentStatusDetailsBreakdownDataType, ErrorItem } from './details/appDetails/appDetails.type'
 import { GroupFilterType } from '../ApplicationGroup/AppGroup.types'
@@ -103,7 +103,7 @@ export interface AppDetails extends CDModalProps {
     appId: number
     deploymentAppType?: DeploymentAppTypes
     externalCi?: boolean
-    userApprovalMetadata?: UserApprovalMetadataType
+    approvalConfigData?: ApprovalConfigDataType
     ciArtifactId?: number
     parentArtifactId?: number
     deprecated?: boolean

diff --git a/src/components/cdPipeline/CDPipeline.tsx b/src/components/cdPipeline/CDPipeline.tsx
@@ -184,8 +184,6 @@ export default function CDPipeline({
             triggerType: TriggerType.Auto,
             steps: [],
         },
-        // Utilizing the null checks to get default value
-        // TODO: Remove
         isClusterCdActive: false,
         deploymentAppCreated: false,
         clusterName: '',