Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct Eq/PartialEq/Hash for VersionReq #13

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix: correct Eq/PartialEq/Hash for VersionReq #13

merged 1 commit into from
Dec 13, 2023

Conversation

lucacasonato
Copy link
Member

Also adds Hash to other types that use VersionReq.

@lucacasonato
fix: correct Eq/PartialEq/Hash for VersionReq
f0b307f 
Also adds Hash to other types that use VersionReq.
dsherret
dsherret approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 98f9174 into main Dec 13, 2023
1 check passed
@lucacasonato lucacasonato deleted the fix_eq_and_hash_for_versionreq branch December 13, 2023 09:23
@dsherret dsherret mentioned this pull request Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @dsherret