fix: revert VersionReq being equal on inner RangeSet #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of #13
Although it seemed like the right idea, the raw text is significant to know about in places like the LSP where we map the raw text back to the package requirement. If we make hashing and equals not based on the raw text, then these "duplicate" package requirements get lost in the npm resolution and it breaks some scenarios like auto-import mapping the version requirement text to a bare specifier in the import map when there are multiple possible version requirements for the same underlying RangeSetOrTag. In other words, the previous commit made us lose some resolution that we need for the LSP.
What we can do in the registry code that relied on this is to convert the
VersionReq
s into the innerRangeSetOrTag
s.