-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/websocket): use rustls-tokio-stream instead of tokio-rustls #20518
Conversation
51b8457
to
5e61e26
Compare
Actually, I think there's still a race condition. The only substantial change I see between this and the previous version is the |
I am starting to suspect it's a handshake issue here... I might integrate fastwebsockets directly as a test in the TLS library to see if I can track this down. |
97ae044
to
624a7f9
Compare
I can confirm this PR fixes at least #20948 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
Can you add to description any issues this PR closes?
Use new https://github.com/denoland/rustls-tokio-stream project instead of tokio-rustls for direct websocket connections. This library was written from the ground up to be more reliable and should help with various bugs that may occur due to underlying bugs in the old library.
Believed to fix #20355, #18977, #20948