WIP: Test for TLS websockets #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to be a test for denoland#18977, but encountering a different issue on the potentially fixed branch, at the moment. A bit stuck as the client here gets an 'InvalidData: invalid data' error right away. Opening a WebSocket from the browser to the server running in the test is fine. And the test passes if the cert/key are commented out and wss -> ws.
|
(Also, I should mention I've tried with and without the |
|
Nothing changed on deno 1.37.1. The WSS server is still firing
|
mmastrac
force-pushed
the
tls
branch
3 times, most recently
from
97ae044 to
624a7f9
Compare
|
Pulling this test into denoland#20518 and closing this one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be a test for denoland#18977, but encountering a different issue on the potentially fixed branch, at the moment.
A bit stuck as the client here gets an 'InvalidData: invalid data' error right away. Opening a WebSocket from the browser to the server running in the test is fine. And the test passes if the cert/key are commented out and wss -> ws.