-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZeroFox] Remove api-token-auth/ call to avoid rate-limits #38493
[ZeroFox] Remove api-token-auth/ call to avoid rate-limits #38493
Conversation
ebb407f
to
b362254
Compare
b362254
to
a2abb72
Compare
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilaredo will know the proposed changes are ready to be reviewed. |
Hi @DNRRomero, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
129e428
to
37fe75f
Compare
Hi @ilaredo , any comments on the PR? one of our customers is pushing for this to be released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DNRRomero, Thank you for your contribution.
The code looks fine to me. Due to the BC, I would like you to create a short video demo showcasing the changes you made and confirming that they work correctly. Please also demonstrate that the test module passes successfully.
Again, thank you for your work, and I look forward to hearing from you.
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2298627 |
@ilaredo Doc review completed. |
37fe75f
to
8a5977f
Compare
Hi @ilaredo |
thanks. |
e71bc24
to
5787108
Compare
5787108
to
517d8f1
Compare
@ilaredo pre-commit is now passing |
218295b
into
demisto:contrib/riskive_zerofox_fix_rate_limits
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
…38593) * remote api call to zerofox's api-token-auth/ endpoint to avoid possible rate limits * Correct documentation suggestion Co-authored-by: Diego Ramirez R <[email protected]>
Remove ZeroFox's api-token-auth/ call which was causing zerofox rate-limits, as reported by users
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Solve reported issues of receiving rate limits by the ZeroFox API, by removing the API call that caused this problems
Must have