Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZeroFox] Remove api-token-auth/ call to avoid rate-limits #38493

Conversation

DNRRomero
Copy link
Contributor

Remove ZeroFox's api-token-auth/ call which was causing zerofox rate-limits, as reported by users

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Solve reported issues of receiving rate limits by the ZeroFox API, by removing the API call that caused this problems

Must have

  • Tests
  • Documentation

@DNRRomero DNRRomero force-pushed the zerofox_fix_rate_limits branch from ebb407f to b362254 Compare February 4, 2025 18:37
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Feb 4, 2025
@content-bot content-bot changed the base branch from master to contrib/riskive_zerofox_fix_rate_limits February 4, 2025 18:38
@DNRRomero DNRRomero force-pushed the zerofox_fix_rate_limits branch from b362254 to a2abb72 Compare February 4, 2025 18:38
@content-bot content-bot requested a review from ilaredo February 4, 2025 18:39
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilaredo will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @DNRRomero, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Feb 4, 2025
@DNRRomero DNRRomero force-pushed the zerofox_fix_rate_limits branch 3 times, most recently from 129e428 to 37fe75f Compare February 6, 2025 13:29
@DNRRomero
Copy link
Contributor Author

Hi @ilaredo , any comments on the PR? one of our customers is pushing for this to be released

@ilaredo ilaredo added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 9, 2025
Copy link
Contributor

@ilaredo ilaredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DNRRomero, Thank you for your contribution.
The code looks fine to me. Due to the BC, I would like you to create a short video demo showcasing the changes you made and confirming that they work correctly. Please also demonstrate that the test module passes successfully.
Again, thank you for your work, and I look forward to hearing from you.

@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2298627

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 9, 2025
@richardbluestone richardbluestone requested review from ShirleyDenkberg and removed request for richardbluestone February 9, 2025 09:16
@ShirleyDenkberg
Copy link
Contributor

@ilaredo Doc review completed.

@DNRRomero DNRRomero force-pushed the zerofox_fix_rate_limits branch from 37fe75f to 8a5977f Compare February 10, 2025 12:27
@DNRRomero
Copy link
Contributor Author

Hi @ilaredo
Demo recording included in submission form, filled out just now

@ilaredo
Copy link
Contributor

ilaredo commented Feb 10, 2025

thanks.
Also please make sure to pass pre-commit step.

@DNRRomero DNRRomero force-pushed the zerofox_fix_rate_limits branch 3 times, most recently from e71bc24 to 5787108 Compare February 10, 2025 16:28
@DNRRomero DNRRomero force-pushed the zerofox_fix_rate_limits branch from 5787108 to 517d8f1 Compare February 10, 2025 17:11
@DNRRomero
Copy link
Contributor Author

@ilaredo pre-commit is now passing

@ilaredo ilaredo merged commit 218295b into demisto:contrib/riskive_zerofox_fix_rate_limits Feb 10, 2025
14 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

ilaredo pushed a commit that referenced this pull request Feb 11, 2025
…38593)

* remote api call to zerofox's api-token-auth/ endpoint to avoid possible rate limits

* Correct documentation suggestion

Co-authored-by: Diego Ramirez R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-demo Demo pending Pending-Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants