Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZeroFox] Remove api-token-auth/ call to avoid rate-limits #38593

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@DNRRomero

Remove ZeroFox's api-token-auth/ call which was causing zerofox rate-limits, as reported by users

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Solve reported issues of receiving rate limits by the ZeroFox API, by removing the API call that caused this problems

Must have

  • Tests
  • Documentation

* remote api call to zerofox's api-token-auth/ endpoint to avoid possible rate limits

* Correct documentation suggestion
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Partner pending-demo Demo pending Contribution Form Filled Whether contribution form filled or not. Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Partner-Approved Pending-Partner labels Feb 10, 2025
@content-bot content-bot requested a review from ilaredo February 10, 2025 19:57
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ZeroFox/Integrations/ZeroFox
   ZeroFox.py7006191%118, 126, 152, 169, 191, 231, 261, 812–813, 832–833, 974, 1304, 1334, 1351, 1368, 1379–1380, 1441–1442, 1504, 1623, 1680–1681, 1685, 1715, 1747, 1845, 1868, 1943, 1973, 2003, 2027, 2050, 2066–2069, 2074, 2077–2079, 2081, 2111–2113, 2123, 2125–2129, 2134–2139, 2141, 2144–2145
TOTAL7006191% 

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 3.489s ⏱️

@ilaredo ilaredo merged commit ae5755f into master Feb 11, 2025
48 checks passed
@ilaredo ilaredo deleted the contrib/riskive_zerofox_fix_rate_limits branch February 11, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-demo Demo pending Pending-Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants