Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/k8s-resources] Add imagePullSecrets to CronJobs #548

Closed
wants to merge 4 commits into from
Closed

[stable/k8s-resources] Add imagePullSecrets to CronJobs #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f447cc
Add imagePullSecrets to CronJobs
Nov 15, 2023
0bcb44f
Regenerate the chart README.md
Nov 15, 2023
d4305b0
Fix lint
Hexcah Nov 22, 2023
a413310
Merge branch 'master' into master
max-rocket-internet Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/k8s-resources/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
version: 0.6.5
appVersion: 0.0.1
version: 0.6.6
name: k8s-resources
description: |
Not an application but a Helm chart to create any and many resources in Kubernetes.
Expand Down
89 changes: 48 additions & 41 deletions stable/k8s-resources/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# k8s-resources

![Version: 0.6.5](https://img.shields.io/badge/Version-0.6.5-informational?style=flat-square) ![AppVersion: 0.0.1](https://img.shields.io/badge/AppVersion-0.0.1-informational?style=flat-square)




![Version: 0.6.6](https://img.shields.io/badge/Version-0.6.6-informational?style=flat-square) ![AppVersion: 0.0.1](https://img.shields.io/badge/AppVersion-0.0.1-informational?style=flat-square)

Not an application but a Helm chart to create any and many resources in Kubernetes.

Currently supports:
Expand All @@ -18,41 +20,46 @@ Currently supports:
- ScaledObject (KEDA)

Every resource type can have custom labels, annotations or a `fullnameOverride` set. See default [values.yaml](https://github.com/deliveryhero/helm-charts/blob/master/stable/k8s-resources/values.yaml) for examples.

**Homepage:** <https://github.com/deliveryhero/helm-charts>

## How to install this chart

Add Delivery Hero public chart repo:

```console
helm repo add deliveryhero https://charts.deliveryhero.io/
```

A simple install with default values:

```console
helm install deliveryhero/k8s-resources
```

To install the chart with the release name `my-release`:

```console
helm install my-release deliveryhero/k8s-resources
```

To install with some set values:

```console
helm install my-release deliveryhero/k8s-resources --set values_key1=value1 --set values_key2=value2
```

To install with custom values file:

```console
helm install my-release deliveryhero/k8s-resources -f values.yaml
```



**Homepage:** <https://github.com/deliveryhero/helm-charts>

## How to install this chart

Add Delivery Hero public chart repo:

```console
helm repo add deliveryhero https://charts.deliveryhero.io/
```

A simple install with default values:

```console
helm install deliveryhero/k8s-resources
```

To install the chart with the release name `my-release`:

```console
helm install my-release deliveryhero/k8s-resources
```

To install with some set values:

```console
helm install my-release deliveryhero/k8s-resources --set values_key1=value1 --set values_key2=value2
```

To install with custom values file:

```console
helm install my-release deliveryhero/k8s-resources -f values.yaml
```





## Values

| Key | Type | Default | Description |
Expand All @@ -69,10 +76,10 @@ helm install my-release deliveryhero/k8s-resources -f values.yaml
| ServiceAccounts | list | `[]` | A list ServiceAccount to create |
| Services | list | `[]` | A list Service to create |
| fullnameOverride | string | `""` | Override the full name of resources |
| nameOverride | string | `""` | Override the name of resources |

| nameOverride | string | `""` | Override the name of resources |
## Maintainers

| Name | Email | Url |
| ---- | ------ | --- |
| max-rocket-internet | <[email protected]> | |
| max-rocket-internet | <[email protected]> | |
2 changes: 2 additions & 0 deletions stable/k8s-resources/ci/ct-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ CronJobs:
- "sh"
- "-c"
- "'echo yes'"
imagePullSecrets:
- name: regcred

ConfigMaps:
- name: example-cm
Expand Down
6 changes: 6 additions & 0 deletions stable/k8s-resources/templates/cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ spec:
{{- with .containers }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if .imagePullSecrets }}
imagePullSecrets:
{{- with .imagePullSecrets }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
---
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions stable/k8s-resources/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ CronJobs: []
# - "sh"
# - "-c"
# - "'echo yes'"
# imagePullSecrets:
# - name : regcred

# ConfigMaps -- A list ConfigMap to create
ConfigMaps: []
Expand Down
Loading