Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/k8s-resources] Add imagePullSecrets to CronJobs #548

Closed
wants to merge 4 commits into from
Closed

[stable/k8s-resources] Add imagePullSecrets to CronJobs #548

wants to merge 4 commits into from

Conversation

Hexcah
Copy link

@Hexcah Hexcah commented Nov 15, 2023

Description

Add imagePullSecrets to CronJobs in k8s-resources

Checklist

  • [ ✔️] Title of the PR starts with chart name (e.g. [stable/mychartname])
  • [ ✔️] I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@Hexcah Hexcah requested a review from a team as a code owner November 15, 2023 14:28
max-rocket-internet
max-rocket-internet approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Hexcah 💜 Fix CI and we are good to merge.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@Hexcah Hexcah closed this by deleting the head repository Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hexcah @max-rocket-internet