fix: remove public-api files to reduce import possibilities #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
davidlj95
commented
Mar 8, 2024
| @@ -2,7 +2,6 @@ | |||
| "$schema": "../../../node_modules/ng-packagr/ng-package.schema.json", | |||
| "dest": "../dist", | |||
| "lib": { | |||
| "entryFile": "public-api.ts" | |||
| }, | |||
| "assets": ["tsdoc-metadata.json"] | |||
There was a problem hiding this comment.
whooops, this was a leftover from when trying to publish that file
davidlj95
deleted the
stacked/fix-remove-public-api-files-to-reduce-import-possibilities
branch
📦 Bundle size (Angular v16)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v17)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
📦 Bundle size (Angular v15)Git ref:
Base size data is not available yet. Try again when the CI/CD has finished running on main branch |
1 task
|
🎉 This PR is included in version 1.0.0-alpha.46 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removes a chance from importing from
public-api.tswhilst we solve Typescript definitions rollup (see #411)Uses
index.tsasng-packagrentry point instead, which will be used for Typescript path mappings too. A file less to maintain indeed.And given we were not separating from public / internal APIs in there, it wasn't really used. So was there to follow the convention mostly
Quick reminders