We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngx-meta
After using latest version of library in a real life app, found out the IDE lets you import same thing from several places.
For instance, if importing something from core entry point, it suggests you can import it from:
core
@davidlj95/ngx-meta/core
@davidlj95/ngx-meta/core/public-api
public-api
@davidlj95/ngx-meta/core/src/some-file
some-file
In order to avoid using non-recommended imports 2/3, we should rollup our Typescript definitions, as Angular Package Format recommends.
API Extractor is recommended for that purpose. Which we already use for the API Report and docs.
However, it is not possible right now to use Typescript definitions rollup when there are secondary entry points
So seems we'll need to go another way
1.0.0-alpha.45
import { GlobalMetadata } from '@davidlj95/ngx-meta/core'
The text was updated successfully, but these errors were encountered:
After #412 , only 1 / 2 options are shown to import:
Sorry, something went wrong.
Aaaaaaand it's gone (#414)
🎉
Had to clear cache of WebStorm. Restarting Typescript service wasn't enough :P
davidlj95
Successfully merging a pull request may close this issue.
Project
ngx-meta
What happened?
After using latest version of library in a real life app, found out the IDE lets you import same thing from several places.
For instance, if importing something from
core
entry point, it suggests you can import it from:@davidlj95/ngx-meta/core
: the right one. Things are actually there for both flattened & unflattened exports.@davidlj95/ngx-meta/core/public-api
: shouldn't be used, as thatpublic-api
file could change@davidlj95/ngx-meta/core/src/some-file
: shouldn't be used, as thatsome-file
filename / path could change.In order to avoid using non-recommended imports 2/3, we should rollup our Typescript definitions, as Angular Package Format recommends.
API Extractor is recommended for that purpose. Which we already use for the API Report and docs.
However, it is not possible right now to use Typescript definitions rollup when there are secondary entry points
So seems we'll need to go another way
Version
1.0.0-alpha.45
Minimal reproduction
Code of Conduct
The text was updated successfully, but these errors were encountered: