fix: use rollup-plugin-dts to rollup TS defs #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
davidlj95
commented
Mar 10, 2024
Comment on lines
+5
to
+9
| input: 'projects/ngx-meta/dist/json-ld/index.d.ts', | ||
| output: { | ||
| format: 'es', | ||
| file: 'projects/ngx-meta/dist/json-ld/bundled.d.ts', | ||
| }, |
There was a problem hiding this comment.
We'd have to see if the plugin supports multiple inputs & output files by name. Some quick tests seemed to indicate it doesn't. So the other alternative would be to call rollup using it's JS API.
davidlj95
commented
Mar 10, 2024
| respectExternal: true, | ||
| }), | ||
| ], | ||
| external: [/node_modules/, /ngx-meta\/dist\/(?!json-ld)/], |
There was a problem hiding this comment.
Ignore references to other ngx-meta entry points, those definitions will be bundled as part of those entry points
davidlj95
force-pushed
the
stacked/fix-use-rollup-plugin-dts-to-rollup-TS-defs
branch
from
1aaf3d3 to
00389ea
Compare
davidlj95
deleted the
stacked/fix-use-rollup-plugin-dts-to-rollup-TS-defs
branch
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Uses
rollup-plugin-dtsto generated bundled Typescript definition files. Why we need those? See #411Eventually this was discarded in favour of #414 as the plugin is in maintenance mode since July 2023
Quick reminders
Relates to issue #411