Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-623 ci: Avoid Jenkins build for Dependabot PR [WIP] #15792

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DAOS-623 ci: Avoid Jenkins build for Dependabot PR [WIP] #15792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@ updates:
- "*"
assignees:
- daos-stack/actions-watchers
commit-message:
prefix: "Doc-only: true \n"
Comment on lines +24 to +25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this adds to the commit title, not the message body. It probably will technically work, but the commit title and PR title will always be "Doc-only: true"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this is the only way to force Jenkins not to build anything that is GHA-only related.
The dependabot can not modify commit message, it only knows how to adjust header.
PR title is usually modified manually later when jira ticket is created.
This mechanism is only to block the Jenkins build when such PR is created by dependabot.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unfortunate. I think let's go with this for now.
But FWIW, the logic that auto determines Test-tag (not mapped to the entire code base yet) could also be adapted for this.
I.e. here

daos/ci/gen_commit_pragmas.py

Lines 87 to 93 in 2530707

modified_files = git_files_changed(target)
if not modified_files:
return pragmas
test_tag = ' '.join(sorted(tags.files_to_tags(modified_files)))
if test_tag:
pragmas['Test-tag'] = test_tag

Could have logic to implement "only GHA was modified so skip jenkins stages"

Loading