-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-623 ci: Avoid Jenkins build for Dependabot PR [WIP] #15792
base: master
Are you sure you want to change the base?
DAOS-623 ci: Avoid Jenkins build for Dependabot PR [WIP] #15792
Conversation
Doc-only: true There is no need to start any action on Jenkins for Dependabot PRs. Signed-off-by: Tomasz Gromadzki <[email protected]>
Ticket title is 'Generic ticket for minor code cleanup and improvement' |
commit-message: | ||
prefix: "Doc-only: true \n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this adds to the commit title, not the message body. It probably will technically work, but the commit title and PR title will always be "Doc-only: true"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this is the only way to force Jenkins not to build anything that is GHA-only related.
The dependabot can not modify commit message, it only knows how to adjust header.
PR title is usually modified manually later when jira ticket is created.
This mechanism is only to block the Jenkins build when such PR is created by dependabot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's unfortunate. I think let's go with this for now.
But FWIW, the logic that auto determines Test-tag
(not mapped to the entire code base yet) could also be adapted for this.
I.e. here
Lines 87 to 93 in 2530707
modified_files = git_files_changed(target) | |
if not modified_files: | |
return pragmas | |
test_tag = ' '.join(sorted(tags.files_to_tags(modified_files))) | |
if test_tag: | |
pragmas['Test-tag'] = test_tag |
Could have logic to implement "only GHA was modified so skip jenkins stages"
DAOS-623 ci: Avoid Jenkins build for Dependabot PR
Doc-only: true
There is no need to start any action on Jenkins for Dependabot PRs.
An example of proposed result is here:
grom72@5cfa1c0
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: