Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-623 ci: Avoid Jenkins build for Dependabot PR [WIP] #15792

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jan 27, 2025

DAOS-623 ci: Avoid Jenkins build for Dependabot PR

Doc-only: true

There is no need to start any action on Jenkins for Dependabot PRs.

An example of proposed result is here:
grom72@5cfa1c0

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Doc-only: true

There is no need to start any action on Jenkins for Dependabot PRs.

Signed-off-by: Tomasz Gromadzki <[email protected]>
Copy link

Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.6.3'
https://daosio.atlassian.net/browse/DAOS-623

Comment on lines +24 to +25
commit-message:
prefix: "Doc-only: true \n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this adds to the commit title, not the message body. It probably will technically work, but the commit title and PR title will always be "Doc-only: true"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this is the only way to force Jenkins not to build anything that is GHA-only related.
The dependabot can not modify commit message, it only knows how to adjust header.
PR title is usually modified manually later when jira ticket is created.
This mechanism is only to block the Jenkins build when such PR is created by dependabot.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unfortunate. I think let's go with this for now.
But FWIW, the logic that auto determines Test-tag (not mapped to the entire code base yet) could also be adapted for this.
I.e. here

modified_files = git_files_changed(target)
if not modified_files:
return pragmas
test_tag = ' '.join(sorted(tags.files_to_tags(modified_files)))
if test_tag:
pragmas['Test-tag'] = test_tag

Could have logic to implement "only GHA was modified so skip jenkins stages"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants