qt: add flexible theming with sensible defaults #780

Mikilio · 2025-01-18T18:01:55Z

This is a continuation of PR #142. It includes some changes I've made in the past, but also my more recent and most important change that hopefully is a good step towards getting this merged. This PR should be carefully reviewed.

Mikilio · 2025-01-18T18:09:32Z

Local testing still in progress

Performed a rebase let me know if you want a merge instead.

These changes make the PR apply the Kvatum theme only when appropriate and creates the framework to allow for Qt styling based on the DE.

Mikilio · 2025-01-19T05:34:11Z

@trueNAHO @danth @bluskript @Jackaed Ready for review

Mistrustfully · 2025-01-23T03:53:12Z

If you don't have stylix.iconTheme.dark set in your config Stylix fails to build:

       … while evaluating a path segment
         at /nix/store/f7gh3ya0is8h5ds22dv1dskl1px7znsh-source/modules/qt/hm.nix:86:24:
           85|             style=${config.qt.style.name}
           86|             icon_theme=${iconTheme}
             |                        ^
           87|           '';

       error: cannot coerce null to a string: null

After setting it however it works fine for me.

Mikilio · 2025-01-23T09:02:10Z

@Mistrustfully What behavior would you have expected here? I kind of intended it to work like that, but if it was perceived as bad UX I'd like to change it.

trueNAHO

Considering that this PR may be somewhat fragile, it would be nice if people that are using or testing this PR could leave a comment whether it works for them, or what does not work. This hopefully gives more confidence in the correctness of this PR.

modules/qt/hm.nix

modules/qt/nixos.nix

eblechschmidt · 2025-01-25T16:55:09Z

I tested this PR and it works for me as well.

The only issue I ran into was the same as above with iconTheme.dark not being set. It would have been helpful to get a more useful error pointing me to setting that option in the HM module.

@Mistrustfully What behavior would you have expected here? I kind of intended it to work like that, but if it was perceived as bad UX I'd like to change it.

I also had to set targets.qt.platform = "qtct" because the default seems to be qt5ct for my system even though I don't set i t anywhere.

Co-authored-by: NAHO <[email protected]>

Mikilio · 2025-01-25T21:12:52Z

I also had to set targets.qt.platform = "qtct" because the default seems to be qt5ct for my system even though I don't set i t anywhere.

Thanks for pointing that out, it was a typo.

Mikilio · 2025-01-26T12:02:36Z

My last commit should fix the issue you encountered when not setting the icon theme. Mind that not setting iconTheme.dark or iconTheme.light will not provide you with an icon theme, but it will also not break the config anymore.

eblechschmidt · 2025-01-26T12:12:46Z

It now errors with the the following:

error:
       … while calling the 'head' builtin
         at /nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/lib/attrsets.nix:1574:11:
         1573|         || pred here (elemAt values 1) (head values) then
         1574|           head values
             |           ^
         1575|         else

       … while evaluating the attribute 'value'
         at /nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/lib/modules.nix:846:9:
          845|     in warnDeprecation opt //
          846|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          847|         inherit (res.defsFinal') highestPrio;

       … while evaluating the option `system.build.toplevel':

       … while evaluating definitions from `/nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/nixos/modules/system/activation/top-level.nix':

       … while evaluating the option `warnings':

       … while evaluating definitions from `/nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/nixos/modules/system/boot/systemd.nix':

       … while evaluating the option `systemd.services.home-manager-eike.serviceConfig':

       … while evaluating definitions from `/nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/flake.nix':

       … while evaluating the option `home-manager.users.eike.home.file."/home/eike/.config/qt5ct/qt5ct.conf".source':

       … while evaluating definitions from `/nix/store/cb0iggncanz0ny51bv8mxidr8zl606vq-source/modules/files.nix':

       … while evaluating the option `home-manager.users.eike.home.file."/home/eike/.config/qt5ct/qt5ct.conf".text':

       … while evaluating definitions from `/nix/store/cb0iggncanz0ny51bv8mxidr8zl606vq-source/modules/misc/xdg.nix':

       … while evaluating the option `home-manager.users.eike.xdg.configFile."qt5ct/qt5ct.conf".text':

       … while evaluating definitions from `/nix/store/162043qziish2zn20aggx6am3s4q96h1-source/modules/qt/hm.nix':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute 'optionString' missing
       at /nix/store/162043qziish2zn20aggx6am3s4q96h1-source/modules/qt/hm.nix:75:16:
           74|             ''
           75|             ++ lib.optionString (config.qt.style ? name) ''
             |                ^
           76|               style=${config.qt.style.name}
       Did you mean optionalString?

Mikilio · 2025-01-26T12:14:51Z

Oops, typo again.

eblechschmidt · 2025-01-26T12:17:49Z

Now I get this error:

error:
       … while calling the 'head' builtin
         at /nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/lib/attrsets.nix:1574:11:
         1573|         || pred here (elemAt values 1) (head values) then
         1574|           head values
             |           ^
         1575|         else

       … while evaluating the attribute 'value'
         at /nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/lib/modules.nix:846:9:
          845|     in warnDeprecation opt //
          846|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          847|         inherit (res.defsFinal') highestPrio;

       … while evaluating the option `system.build.toplevel':

       … while evaluating definitions from `/nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/nixos/modules/system/activation/top-level.nix':

       … while evaluating the option `warnings':

       … while evaluating definitions from `/nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/nixos/modules/system/boot/systemd.nix':

       … while evaluating the option `systemd.services.home-manager-eike.serviceConfig':

       … while evaluating definitions from `/nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source/flake.nix':

       … while evaluating the option `home-manager.users.eike.home.file."/home/eike/.config/qt5ct/qt5ct.conf".source':

       … while evaluating definitions from `/nix/store/cb0iggncanz0ny51bv8mxidr8zl606vq-source/modules/files.nix':

       … while evaluating the option `home-manager.users.eike.home.file."/home/eike/.config/qt5ct/qt5ct.conf".text':

       … while evaluating definitions from `/nix/store/cb0iggncanz0ny51bv8mxidr8zl606vq-source/modules/misc/xdg.nix':

       … while evaluating the option `home-manager.users.eike.xdg.configFile."qt5ct/qt5ct.conf".text':

       … while evaluating definitions from `/nix/store/3drfha8hnp71mvf1dwaazijll293rg4h-source/modules/qt/hm.nix':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: expected a list but found a string: "style=kvantum\n"

eblechschmidt · 2025-01-26T12:21:40Z

Ok, now it works again 👍

Co-authored-by: NAHO <[email protected]>

Mikilio · 2025-01-28T20:55:18Z

@trueNAHO only 1 convo left. If you agree with the solution you can just check it off.

trueNAHO

LGTM.

Thanks to everyone involved in this feature. Great to see this getting merged.

With commit b7f50a5 ("qt: add flexible theming with sensible defaults (danth#780)"), the Qt pinentry package is a reasonable default value: > NixOS stopped building gtk2 pinentry by default in > NixOS/nixpkgs#270266 and there does not appear > to be a reasonable other default. > > -- home-manager, "gpg-agent: don't set a default for pinentry", > nix-community/home-manager@4585445 Closes: danth#184

Link: #830 Fixes: b7f50a5 ("qt: add flexible theming with sensible defaults (#780)") Reviewed-by: NAHO <[email protected]>

Fixes: b7f50a5 ("qt: add flexible theming with sensible defaults (danth#780)")

Fixes #780

Mikilio force-pushed the pr-142 branch 4 times, most recently from b6d4e66 to dd58e80 Compare January 18, 2025 18:46

bluskript and others added 10 commits January 18, 2025 19:53

add kvantum theming support

f24ec3f

add all required packages

a910c66

remove eol package

3060471

add default icon

8ebfc47

fix sway xcursor theme setting

d1d46ec

Rename module to qt, fix kvantum theme application

059796b

implement requested changes

e90d63a

Replace default icon theme option with an icon theme name option

69254a7

Revert platformTheme change name

a9fc9ef

fix: remove warning platformTheme -> platformTheme.name

513b62b

Mikilio force-pushed the pr-142 branch 4 times, most recently from 8a1405f to d3865d9 Compare January 19, 2025 05:22

feat(qt): integrate qt hm module with NixOS for sensible defaults

bf2601d

These changes make the PR apply the Kvatum theme only when appropriate and creates the framework to allow for Qt styling based on the DE.

Mikilio force-pushed the pr-142 branch from d3865d9 to bf2601d Compare January 19, 2025 05:26

Mikilio mentioned this pull request Jan 23, 2025

kde: replace kdeglobals with Kvantum theme #142

Closed

trueNAHO requested changes Jan 23, 2025

View reviewed changes

trueNAHO changed the title ~~Add flexible Qt theming with sensible defaults.~~ qt: add flexible theming with sensible defaults Jan 23, 2025

Mikilio force-pushed the pr-142 branch from 8deadce to 5249686 Compare January 24, 2025 21:51

Mikilio requested a review from trueNAHO January 24, 2025 21:54

Apply suggestions from code review

53397b0

Co-authored-by: NAHO <[email protected]>

Mikilio force-pushed the pr-142 branch from 5249686 to 53397b0 Compare January 25, 2025 21:12

Mikilio force-pushed the pr-142 branch from 896c24d to 3478a81 Compare January 26, 2025 12:14

fix(qt): ensure better behavior on unset variables

d4c02e1

Mikilio force-pushed the pr-142 branch from 3478a81 to d4c02e1 Compare January 26, 2025 12:17

Update modules/qt/hm.nix

5f661a2

Co-authored-by: NAHO <[email protected]>

Mikilio force-pushed the pr-142 branch 2 times, most recently from 6ab23a1 to f29e5f3 Compare January 28, 2025 20:40

fix: better checks & warnings

0d79e3d

Mikilio force-pushed the pr-142 branch from f29e5f3 to 0d79e3d Compare January 28, 2025 20:53

trueNAHO approved these changes Feb 3, 2025

View reviewed changes

trueNAHO merged commit b7f50a5 into danth:master Feb 3, 2025
49 checks passed

trueNAHO pushed a commit that referenced this pull request Feb 3, 2025

qt: fix qt6ct directory name (#830)

8be2aed

Link: #830 Fixes: b7f50a5 ("qt: add flexible theming with sensible defaults (#780)") Reviewed-by: NAHO <[email protected]>

FirelightFlagboy mentioned this pull request Feb 4, 2025

kde: Dolphin using wrong font color for the selected theme #833

Closed

trueNAHO added a commit to trueNAHO/stylix that referenced this pull request Feb 9, 2025

qt: respect stylix.enable

ac3728f

Fixes: b7f50a5 ("qt: add flexible theming with sensible defaults (danth#780)")

danth pushed a commit that referenced this pull request Feb 10, 2025

qt: respect stylix.enable (#847)

2c1d493

Fixes #780

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qt: add flexible theming with sensible defaults #780

qt: add flexible theming with sensible defaults #780

Mikilio commented Jan 18, 2025

Mikilio commented Jan 18, 2025 •

edited

Loading

Mikilio commented Jan 19, 2025

Mistrustfully commented Jan 23, 2025

Mikilio commented Jan 23, 2025

trueNAHO left a comment

eblechschmidt commented Jan 25, 2025

Mikilio commented Jan 25, 2025

Mikilio commented Jan 26, 2025

eblechschmidt commented Jan 26, 2025

Mikilio commented Jan 26, 2025

eblechschmidt commented Jan 26, 2025

eblechschmidt commented Jan 26, 2025

Mikilio commented Jan 28, 2025

trueNAHO left a comment

qt: add flexible theming with sensible defaults #780

qt: add flexible theming with sensible defaults #780

Conversation

Mikilio commented Jan 18, 2025

Mikilio commented Jan 18, 2025 • edited Loading

Mikilio commented Jan 19, 2025

Mistrustfully commented Jan 23, 2025

Mikilio commented Jan 23, 2025

trueNAHO left a comment

Choose a reason for hiding this comment

eblechschmidt commented Jan 25, 2025

Mikilio commented Jan 25, 2025

Mikilio commented Jan 26, 2025

eblechschmidt commented Jan 26, 2025

Mikilio commented Jan 26, 2025

eblechschmidt commented Jan 26, 2025

eblechschmidt commented Jan 26, 2025

Mikilio commented Jan 28, 2025

trueNAHO left a comment

Choose a reason for hiding this comment

Mikilio commented Jan 18, 2025 •

edited

Loading