Apply suggestions from code review

Co-authored-by: NAHO <[email protected]>
danth · Jan 24, 2025 · 8deadce · 8deadce
1 parent bf2601d
commit 8deadce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/modules/qt/hm.nix b/modules/qt/hm.nix
@@ -52,28 +52,24 @@
         '';
     in
     {
-      warnings = lib.optional (cfg.targets.qt.platform != "qtct") ''
-        Stylix has not yet implemented qt styling for any platforms other than "qtct".
-        We are working on it.
-      '';
+      warnings =
+        lib.optional
+        (cfg.targets.qt.platform != "qtct")
+        "stylix: qt: config.stylix.targets.qt.platform other than 'qtct' are currently unsupported: ${config.stylix.targets.qt.platform}. Support may be added in the future.";
 
       home.packages = lib.optional (config.qt.style.name == "kvantum") kvantumPackage;
 
       qt = {
         enable = true;
-        style.name = lib.mkIf (
-          recommendedStyle ? "${config.qt.platformTheme.name}"
-        ) recommendedStyle."${config.qt.platformTheme.name}";
+        style.name = recommendedStyle."${config.qt.platformTheme.name}" or null;
         platformTheme.name = cfg.targets.qt.platform;
       };
 
       xdg.configFile = lib.mkMerge [
         (lib.mkIf (config.qt.style.name == "kvantum") {
           "Kvantum/kvantum.kvconfig".source =
             (pkgs.formats.ini { }).generate "kvantum.kvconfig"
-              {
-                General.theme = "Base16Kvantum";
-              };
+              { General.theme = "Base16Kvantum"; };
 
           "Kvantum/Base16Kvantum".source =
             "${kvantumPackage}/share/Kvantum/Base16Kvantum";

diff --git a/modules/qt/nixos.nix b/modules/qt/nixos.nix
@@ -31,7 +31,6 @@ in
   };
 
   config = lib.mkIf (config.stylix.enable && config.stylix.targets.qt.enable) {
-
     stylix.targets.qt.platform =
       if config.services.xserver.desktopManager.gnome.enable then
         lib.mkDefault "gnome"
@@ -52,6 +51,5 @@ in
         else
           config.stylix.targets.qt.platform;
     };
-
   };
 }