Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default size to the mapping #150

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

msmakouz
Copy link
Member

What was changed

This PR adds default size values to the mapping. The same value as the default value in the methods:
https://github.com/cycle/database/blob/2.x/src/Schema/AbstractColumn.php#L574
https://github.com/cycle/database/blob/2.x/src/Driver/MySQL/Schema/MySQLColumn.php#L329

Why?

Without this change, the size is not set when creating a column by calling the type method:
https://github.com/cycle/database/blob/2.x/src/Schema/AbstractColumn.php#L477

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbdb864) 95.10% compared to head (52d2745) 95.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #150   +/-   ##
=========================================
  Coverage     95.10%   95.10%           
  Complexity     1812     1812           
=========================================
  Files           129      129           
  Lines          4987     4987           
=========================================
  Hits           4743     4743           
  Misses          244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit d33b9c2 into 2.x Dec 20, 2023
39 checks passed
@roxblnfk roxblnfk deleted the bugfix/string-default-size branch December 20, 2023 14:46
@roxblnfk roxblnfk added this to the 2.7.x milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants