Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the method only if there are additional options #69

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Dec 19, 2023

Related to: cycle/database#149

And added PHP 8.2-8.3 to GitHub actions.

@msmakouz msmakouz added the type:bug Bug label Dec 19, 2023
@msmakouz msmakouz requested a review from roxblnfk December 19, 2023 11:37
@msmakouz msmakouz self-assigned this Dec 19, 2023
@msmakouz msmakouz marked this pull request as draft December 20, 2023 09:01
@msmakouz msmakouz marked this pull request as ready for review December 20, 2023 14:15
@roxblnfk
Copy link
Member

roxblnfk commented Dec 21, 2023

Need to require cycle/database ^2.7.1

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f2f426) 94.32% compared to head (6c0f4fb) 94.32%.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x      #69   +/-   ##
=========================================
  Coverage     94.32%   94.32%           
- Complexity      556      557    +1     
=========================================
  Files            44       44           
  Lines          1569     1569           
=========================================
  Hits           1480     1480           
  Misses           89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz
Copy link
Member Author

Need to require cycle/database ^2.7.1

Done.

@roxblnfk roxblnfk merged commit 6cbdc76 into 2.x Dec 22, 2023
38 checks passed
@roxblnfk roxblnfk deleted the bugfix/creating-column branch December 22, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants