Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI by pinning node version #2297

Merged
merged 2 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: package.json
node-version-file: .nvmrc
cache: pnpm
- run: pnpm --color install
- run: pnpm --color compile
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: package.json
node-version-file: .nvmrc
cache: pnpm
- run: pnpm --color install
- uses: pre-commit/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ jobs:
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: package.json
node-version-file: .nvmrc
cache: pnpm
- run: bash -x scripts/build-and-assemble-website.sh
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version-file: package.json
node-version-file: .nvmrc
cache: pnpm
- run: mkdir -p "${{ env.VSCODE_CRASH_DIR }}" "${{ env.VSCODE_LOGS_DIR }}"
shell: bash
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v20.12.1
34 changes: 20 additions & 14 deletions packages/test-harness/src/launchVscodeAndRunTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,26 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) {
resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);

// Install extension dependencies
cp.spawnSync(
cli,
[
...args,
...extensionDependencies.flatMap((dependency) => [
"--install-extension",
dependency,
]),
],
{
encoding: "utf-8",
stdio: "inherit",
},
);
const extensionInstallArgs = [
...args,
...extensionDependencies.flatMap((dependency) => [
"--install-extension",
dependency,
]),
];

console.log("starting to install dependency extensions");
console.log(`cli: ${cli}`);
console.log(JSON.stringify(extensionInstallArgs, null, 2));

const { status, signal, error } = cp.spawnSync(cli, extensionInstallArgs, {
encoding: "utf-8",
stdio: "inherit",
});

console.log("status: ", status);
console.log("signal: ", signal);
console.log("error: ", error);

console.log("finished installing dependency extensions");

Expand Down
Loading