Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI by pinning node version #2297

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

pokey
Copy link
Member

@pokey pokey commented Apr 17, 2024

Windows CI started failing due to a node.js regression. We should really be pinning node, like we pin pnpm and all our pnpm dependencies. The only things we don't want to pin are OS version and vscode version

This PR pins node and adds some debug output for the future

Checklist

  • Pin node using technique removed from Bump CI node version to 20 #2217
  • Double-check pnpm pinning
  • Keep some of the print statements here
  • Remove code that slices args
  • Add checklist somewhere of versions to check when this kind of thing happens
    • node version (note this will be pinned)
    • OS version
    • vscode version
  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@pokey pokey force-pushed the pokey/attempt-to-fix-windows-ci branch from 4ef6e65 to f21243e Compare April 18, 2024 17:21
@pokey
Copy link
Member Author

pokey commented Apr 18, 2024

@AndreasArvidsson on second thought, I'm not convinced adding a checklist with two things in it somewhere in our docs will be helpful, but if your gut still says this will be useful I'm happy to drop it somewhere

@pokey pokey changed the title Attempt to fix Windows CI Fix Windows CI Apr 18, 2024
@pokey pokey changed the title Fix Windows CI Fix Windows CI by pinning node version Apr 18, 2024
@pokey pokey marked this pull request as ready for review April 18, 2024 18:02
@pokey pokey requested a review from AndreasArvidsson as a code owner April 18, 2024 18:02
@AndreasArvidsson
Copy link
Member

@AndreasArvidsson on second thought, I'm not convinced adding a checklist with two things in it somewhere in our docs will be helpful, but if your gut still says this will be useful I'm happy to drop it somewhere

Maybe not. I could go either way.

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 957caee Apr 18, 2024
14 checks passed
@AndreasArvidsson AndreasArvidsson deleted the pokey/attempt-to-fix-windows-ci branch April 18, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants