Bump CI node version to 20 #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Feb 1, 2024
pokey
force-pushed
the
pokey/bump-node-version
branch
from
d5e4087 to
f7321ff
Compare
pokey
commented
Feb 1, 2024
| with: | ||
| fetch-depth: 0 | ||
| - uses: pnpm/action-setup@v2 | ||
| - uses: actions/setup-node@v3 | ||
| - run: corepack enable |
There was a problem hiding this comment.
AndreasArvidsson
approved these changes
Feb 3, 2024
cursorless-bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
To get rid of deprecation warnings, eg https://github.com/cursorless-dev/cursorless/actions/runs/7742075291. See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ for more info ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
This was referenced Apr 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Windows CI started failing due to a node.js regression. We should really be pinning node, like we pin pnpm and all our pnpm dependencies. The only things we don't want to pin are OS version and vscode version This PR pins node and adds some debug output for the future ## Checklist - [x] Pin node using technique removed from #2217 - [x] Double-check pnpm pinning - [x] Keep some of the print statements here - [x] Remove code that slices args - [ ] Add checklist somewhere of versions to check when this kind of thing happens - [ ] node version (note this will be pinned) - [ ] OS version - [ ] vscode version - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get rid of deprecation warnings, eg https://github.com/cursorless-dev/cursorless/actions/runs/7742075291. See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ for more info
Checklist