fix(server-core): Handle empty query in getSqlGenerator #9270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
force-pushed
the
sql-api-nondefault-datasouce-confusion
branch
from
a03d9dd to
cf0379e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mcheshkov
force-pushed
the
sql-api-nondefault-datasouce-confusion
branch
from
cf0379e to
9942770
Compare
mcheshkov
changed the title
ovr
approved these changes
Feb 26, 2025
api-gateway calls getSqlGenerator with empty query and concrete data source to initialize SQL API But because query is empty `sqlGenerator.dataSource` can be undefined, and it would trigger re-creating query with new data source, which would be `default`
mcheshkov
force-pushed
the
sql-api-nondefault-datasouce-confusion
branch
from
9942770 to
cb81b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
api-gateway calls getSqlGenerator with empty query and concrete data source to initialize SQL API But because query is empty
sqlGenerator.dataSourcecan be undefined, and it would trigger re-creating query with new data source, which would bedefault