Skip to content

Commit

Permalink
[WIP] test: Add multidb SQL pushdown smoke test
Browse files Browse the repository at this point in the history
  • Loading branch information
mcheshkov committed Feb 26, 2025
1 parent 87a7e5f commit cf0379e
Show file tree
Hide file tree
Showing 3 changed files with 81 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`multidb SQL pushdown queries to different data sources: Products 1`] = `
Array [
Object {
"name": "apples",
},
]
`;

exports[`multidb SQL pushdown queries to different data sources: Suppliers 1`] = `
Array [
Object {
"company": "Fruits Inc",
},
]
`;

exports[`multidb query: query 1`] = `
Array [
Object {
Expand Down
1 change: 1 addition & 0 deletions packages/cubejs-testing/test/smoke-cubesql.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ describe('SQL API', () => {
const pgPort = 5656;
let connectionId = 0;

// TODO extract this
async function createPostgresClient(user: string, password: string) {
connectionId++;
const currentConnId = connectionId;
Expand Down
64 changes: 64 additions & 0 deletions packages/cubejs-testing/test/smoke-multidb.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { MysqlDBRunner, PostgresDBRunner } from '@cubejs-backend/testing-shared'
import cubejs, { CubeApi } from '@cubejs-client/core';
// eslint-disable-next-line import/no-extraneous-dependencies
import { afterAll, beforeAll, expect, jest } from '@jest/globals';
import { Client as PgClient } from 'pg';
import { BirdBox, getBirdbox } from '../src';
import {
DEFAULT_API_TOKEN,
Expand All @@ -18,6 +19,37 @@ describe('multidb', () => {
let birdbox: BirdBox;
let client: CubeApi;

// TODO bunch of this is a copy-paste
let connection: PgClient;
// TODO: Random port?
const pgPort = 5656;
let connectionId = 0;
async function createPostgresClient(user: string, password: string) {
connectionId++;
const currentConnId = connectionId;

console.debug(`[pg] new connection ${currentConnId}`);

const conn = new PgClient({
database: 'db',
port: pgPort,
host: '127.0.0.1',
user,
password,
ssl: false,
});
conn.on('error', (err) => {
console.log(err);
});
conn.on('end', () => {
console.debug(`[pg] end ${currentConnId}`);
});

await conn.connect();

return conn;
}

beforeAll(async () => {
db = await PostgresDBRunner.startContainer({});
db2 = await MysqlDBRunner.startContainer({});
Expand All @@ -39,6 +71,9 @@ describe('multidb', () => {
CUBEJS_DB_USER2: 'root',
CUBEJS_DB_PASS2: 'Test1test',

CUBEJS_PG_SQL_PORT: `${pgPort}`,
CUBESQL_SQL_PUSH_DOWN: 'true',

...DEFAULT_CONFIG,
},
{
Expand All @@ -49,6 +84,7 @@ describe('multidb', () => {
client = cubejs(async () => DEFAULT_API_TOKEN, {
apiUrl: birdbox.configuration.apiUrl,
});
connection = await createPostgresClient('admin', 'admin_password');

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "admin" is used as
user name
.
}, JEST_BEFORE_ALL_DEFAULT_TIMEOUT);

afterAll(async () => {
Expand All @@ -69,4 +105,32 @@ describe('multidb', () => {
});
expect(response.rawData()).toMatchSnapshot('query');
});

test('SQL pushdown queries to different data sources: Products', async () => {
const res = await connection.query(`
SELECT
name
FROM
Products
WHERE
LOWER(name) = 'apples'
GROUP BY
1
`);
expect(res.rows).toMatchSnapshot();
});

test('SQL pushdown queries to different data sources: Suppliers', async () => {
const res = await connection.query(`
SELECT
company
FROM
Suppliers
WHERE
LOWER(company) = 'fruits inc'
GROUP BY
1
`);
expect(res.rows).toMatchSnapshot();
});
});

0 comments on commit cf0379e

Please sign in to comment.