Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql) Fix CASE type with NULL values #7672

Merged
merged 1 commit into from
Feb 5, 2024

fix(cubesql): Fix `CASE` type with `NULL` values

67960e6
Select commit
Loading
Failed to load commit list.
Merged

fix(cubesql) Fix CASE type with NULL values #7672

fix(cubesql): Fix `CASE` type with `NULL` values
67960e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 5, 2024 in 0s

72.83% (-0.03%) compared to 64a7ebd

View this Pull Request on Codecov

72.83% (-0.03%) compared to 64a7ebd

Details

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (64a7ebd) 72.85% compared to head (67960e6) 72.83%.

Files Patch % Lines
rust/cubesql/cubesql/src/compile/engine/udf.rs 57.14% 6 Missing ⚠️
...st/cubesql/cubesql/src/compile/engine/df/coerce.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7672      +/-   ##
==========================================
- Coverage   72.85%   72.83%   -0.03%     
==========================================
  Files         335      335              
  Lines       56945    56996      +51     
  Branches     5238     5238              
==========================================
+ Hits        41490    41511      +21     
- Misses      15261    15291      +30     
  Partials      194      194              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.