fix(cubesql) Fix CASE type with NULL values
#7672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7672 +/- ##
==========================================
- Coverage 72.85% 72.83% -0.03%
==========================================
Files 335 335
Lines 56945 56996 +51
Branches 5238 5238
==========================================
+ Hits 41490 41511 +21
- Misses 15261 15291 +30
Partials 194 194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
paveltiunov
approved these changes
Jan 31, 2024
MazterQyou
force-pushed
the
cubesql/case-expr-type
branch
from
759c675 to
8172d01
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
MazterQyou
force-pushed
the
cubesql/case-expr-type
branch
from
8172d01 to
67960e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR fixes an issue with
CASEexpressions having an incorrect type due to picking the first value among the selection which might beNULL(Utf8type).NULLis now interpreted asScalarValue::Null, allowing coercions of the latter with most of the types. Related test is included.