Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat field #161

Merged
merged 20 commits into from
Jan 30, 2025
Merged

Flat field #161

merged 20 commits into from
Jan 30, 2025

Conversation

ArmelleJB
Copy link
Contributor

Add component, container and tool for calculation of flat field coefficients.

Copy link
Collaborator

@jlenain jlenain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ArmelleJB !
Many thanks for this PR. I'll mark it as draft for the time being, as I understand it is not yet complete.
At some point, in your user script, could you provide an example on how to launch a flatfield computation please ?
Could you also please run pre-commit hooks and commit the linted code ?

@jlenain jlenain marked this pull request as draft November 29, 2024 14:04
@jlenain
Copy link
Collaborator

jlenain commented Jan 16, 2025

Hi!

The PR #163 has been merged, which results in a couple of small conflicts in this one that I'll try to resolve.

@jlenain
Copy link
Collaborator

jlenain commented Jan 16, 2025

Note that I had to rebase this branch from main, but a good point is that the CI/Lint job now passes !

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 53.53535% with 46 lines in your changes missing coverage. Please review.

Project coverage is 63.03%. Comparing base (b306f30) to head (cd8eeef).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...archain/makers/component/preflatfield_component.py 36.36% 42 Missing ⚠️
...nectarchain/makers/calibration/flatfield_makers.py 69.23% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #161       +/-   ##
===========================================
+ Coverage   40.76%   63.03%   +22.26%     
===========================================
  Files          65       66        +1     
  Lines        4452     4829      +377     
===========================================
+ Hits         1815     3044     +1229     
+ Misses       2637     1785      -852     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain jlenain marked this pull request as ready for review January 30, 2025 15:02
Copy link
Collaborator

@jlenain jlenain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks again, @ArmelleJB !

@jlenain jlenain merged commit fa2fed9 into cta-observatory:main Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants