-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flat field #161
Flat field #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ArmelleJB !
Many thanks for this PR. I'll mark it as draft for the time being, as I understand it is not yet complete.
At some point, in your user script, could you provide an example on how to launch a flatfield computation please ?
Could you also please run pre-commit hooks and commit the linted code ?
Hi! The PR #163 has been merged, which results in a couple of small conflicts in this one that I'll try to resolve. |
Note that I had to rebase this branch from |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
===========================================
+ Coverage 40.76% 63.03% +22.26%
===========================================
Files 65 66 +1
Lines 4452 4829 +377
===========================================
+ Hits 1815 3044 +1229
+ Misses 2637 1785 -852 ☔ View full report in Codecov by Sentry. |
…ield from list to np ndarray
…to calculate gain, hi/lo ratio and identify bad pixels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks again, @ArmelleJB !
Add component, container and tool for calculation of flat field coefficients.