Skip to content

Commit

Permalink
Fix conflicts following merge of PR #163
Browse files Browse the repository at this point in the history
  • Loading branch information
jlenain committed Jan 16, 2025
1 parent 61e8031 commit cf1a1df
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 12 deletions.
3 changes: 2 additions & 1 deletion src/nectarchain/data/container/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
get_array_keys,
merge_map_ArrayDataContainer,
)
from .flatfield_container import FlatFieldContainer
from .gain_container import GainContainer, SPEfitContainer
from .pedestal_container import (
NectarCAMPedestalContainer,
Expand All @@ -32,5 +33,5 @@
"NectarCAMPedestalContainer",
"NectarCAMPedestalContainers",
"PedestalFlagBits",
"FlatFieldContainer",
]
from .flatfieldContainer import *
7 changes: 1 addition & 6 deletions src/nectarchain/makers/calibration/flatfield_makers.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,10 @@
from nectarchain.makers import EventsLoopNectarCAMCalibrationTool
from nectarchain.makers.component import NectarCAMComponent

from .core import NectarCAMCalibrationTool

logging.basicConfig(format="%(asctime)s %(name)s %(levelname)s %(message)s")
log = logging.getLogger(__name__)
log.handlers = logging.getLogger("__main__").handlers

from .core import NectarCAMCalibrationTool

__all__ = ["FlatfieldNectarCAMCalibrationTool"]


Expand All @@ -23,7 +19,7 @@ class FlatfieldNectarCAMCalibrationTool(EventsLoopNectarCAMCalibrationTool):

componentsList = ComponentNameList(
NectarCAMComponent,
default_value=["preFlatFieldComponent"],
default_value=["PreFlatFieldComponent"],
help="List of Component names to be apply, the order will be respected",
).tag(config=True)

Expand All @@ -35,4 +31,3 @@ def _init_output_path(self):
self.output_path = pathlib.Path(

Check warning on line 31 in src/nectarchain/makers/calibration/flatfield_makers.py

View check run for this annotation

Codecov / codecov/patch

src/nectarchain/makers/calibration/flatfield_makers.py#L30-L31

Added lines #L30 - L31 were not covered by tests
f"{os.environ.get('NECTARCAMDATA','/tmp')}/FlatFieldTests/{filename}"
)

5 changes: 2 additions & 3 deletions src/nectarchain/makers/component/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@
from .pedestal_component import PedestalEstimationComponent
from .photostatistic_algorithm import PhotoStatisticAlgorithm
from .photostatistic_component import PhotoStatisticNectarCAMComponent
from .preflatfield_component import PreFlatFieldComponent
from .spe import SPECombinedalgorithm, SPEHHValgorithm, SPEHHVStdalgorithm
from .waveforms_component import WaveformsComponent
from .preFlatFieldComponent impor


__all__ = [
"ArrayDataComponent",
Expand All @@ -34,5 +33,5 @@
"PhotoStatisticNectarCAMComponent",
"PhotoStatisticAlgorithm",
"GainNectarCAMComponent",
"preFlatFieldComponent",
"PreFlatFieldComponent",
]
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
log = logging.getLogger(__name__)
log.handlers = logging.getLogger("__main__").handlers

__all__ = ["preFlatFieldComponent"]
__all__ = ["PreFlatFieldComponent"]


class preFlatFieldComponent(NectarCAMComponent):
class PreFlatFieldComponent(NectarCAMComponent):
"""
Component that computes flat field coefficients from raw data.
Expand Down

0 comments on commit cf1a1df

Please sign in to comment.