Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to EventSource for support of CTAO reference metadata #2644

Closed
wants to merge 1 commit into from

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 11, 2024

  • Set to false for SimTelEventSource
  • Silences a warning for SimTelEventSource, which at least currently cannot support the reference metadata.

* Silences a warning for SimTelEventSource, which at least currently
  cannot support the reference metadata.
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (94.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@maxnoe maxnoe added this to the 0.23.0 milestone Nov 12, 2024
@maxnoe maxnoe marked this pull request as draft November 12, 2024 16:20
@maxnoe
Copy link
Member Author

maxnoe commented Nov 12, 2024

I think a better solution would be #2648

@maxnoe
Copy link
Member Author

maxnoe commented Nov 13, 2024

Closing in favor of #2648

@maxnoe maxnoe closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants