Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning MissingReferenceMetadata when running unit test tests/unit_tests/simtel/test_simulator_light_emission.py::test_plot_simtel_ctapipe #1168

Closed
GernotMaier opened this issue Sep 26, 2024 · 3 comments

Comments

@GernotMaier
Copy link
Contributor

pytest --no-cov tests/unit_tests/simtel/test_simulator_light_emission.py::test_plot_simtel_ctapipe gives the following warning:

/Users/maierg/micromamba/envs/simtools-dev/lib/python3.11/site-packages/ctapipe/core/provenance.py:332: MissingReferenceMetadata: Could not read reference metadata for input file: /Users/maierg/DESYCloud/CTA/Pipelines/MC-Pipeline/gammasim-tools/simtools/tests/resources/xyzls_layout.simtel.gz

This should be fixed.

@maxnoe
Copy link

maxnoe commented Nov 11, 2024

I think this is as much an issue for ctapipe as here.

At the moment, we know that we cannot expect this metadata in simtel files, so ctapipe shouldn't warn about it.

In the long-term, simpipe should make sure that the required CTAO reference metadata is stored, by using the simtel metaparams system and ctapipe should read it.

I opened a PR in ctapipe to silence this warning for now here:
cta-observatory/ctapipe#2644

@orelgueta
Copy link
Contributor

A fix for this was introduced in cta-observatory/ctapipe#2648 which was included in ctapipe v0.23.0. I do not see the warning anymore when running

pytest --no-cov tests/unit_tests/simtel/test_simulator_light_emission.py::test_plot_simtel_ctapipe

Can we therefore close this issue?

@GernotMaier
Copy link
Contributor Author

Yes, we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants