Add Typing/MacroCallArgumentTypeRestriction

[nobodywasishere]

No description provided.

[veelenga]

LGTM. Nice one

[Sija]

Aside of the review comments, I'm missing here a default_value rule option, which would exclude the cases where the default value is given.

[Sija]

Also, I believe sth like a MacroCallArgumentTypeRestriction would fit better as the rule name.

[Sija]

At this point the record macro IMO doesn't seem to fit into this, since:

1. It doesn't accept most of the argument types
2. With the Assign nodes, the argument type is still inferred

[nobodywasishere]

It doesn't accept most of the argument types

I don't see this as an issue. It accepts Assign, which is the majority of uses of all of these macro calls.

With the Assign nodes, the argument type is still inferred

This series of PRs is explicitly about removing this inference, so I disagree and think that the record macro still fits.

[veelenga]

I agree with @nobodywasishere on keeping record in the list. But would it make sense to default default_value to false? While typing restrictions are helpful, I think the primary goal is readability, and sometimes type inference just does the job. For example, this is totally fine

record Task,
  cmd = "ameba",
  args = [] of String

and we don't have to enforce this by default:

record Task,
  cmd : String = "ameba",
  args : Array(String) = [] of String

[nobodywasishere]

@veelenga That's how I should've done it (and how I did it in the other typing rules), where when enabled, it's the least-restrictive form of the rule, with the option to go more restrictive.

I think the primary goal is readability

A secondary goal for me is in tooling, where I will probably use this and other rules to enforce types so a language server has an easier time figuring out what the types of things are.