Update "Deploy Linked Token" GH action to support Proxy upgrade pattern #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation instance of the same code and pretter
…pyard/ipc into mikers/linkedTokenUpgrades
snissn
changed the title
snissn
changed the title
snissn
changed the title
|
@maciejwitowski that assumption is correct. I was optimistically working on this and it's also turning into a large time sync. The code has a dependency on a server that I don't know the details about, takes a long time to run so it's hard to test, and seemed to have quirks that I haven't gotten deep into where it would be flaky - I think due to multiple runs of tests happening a time. For now I had just left it but do not have a clear plan because of the cost benefit analysis on how much time to fix vs how much its worth fixing. |
|
@consensus-shipyard/ipc-core-devs I would suggest to close the issue as it is not something critical and it does not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for proxy upgrades to the linked_token_deployment branch which is now in Main.
Currently the check makes it to
make deploy-replica-proxyand then fails with the error:next step to investigate that is to see if the account sending transactions related to the linked token is separate from an ipc validator and to make it its own funded account if it is not
This change is