Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to auto deploy and test linked token contracts #789

Closed
wants to merge 25 commits into from

Conversation

mb1896
Copy link
Contributor

@mb1896 mb1896 commented Mar 12, 2024

@mb1896 mb1896 changed the title Test workflow for deploy linked tokens contracts Workflow to auto deploy and test linked token contracts Mar 13, 2024
@mb1896 mb1896 force-pushed the linked_token_deployment branch from c45abbb to b7e78dc Compare March 15, 2024 05:55
@mb1896 mb1896 force-pushed the linked_token_deployment branch from b7e78dc to b2d00d5 Compare March 15, 2024 20:12
@mb1896 mb1896 marked this pull request as ready for review March 15, 2024 21:29
@mb1896 mb1896 requested a review from raulk March 15, 2024 21:30
@mb1896 mb1896 requested review from snissn and aakoshh March 15, 2024 21:30

on:
workflow_dispatch:
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove pull_request: before PR merges.

@raulk raulk marked this pull request as draft April 15, 2024 14:46
@raulk
Copy link
Contributor

raulk commented Apr 15, 2024

The LinkedToken is now an upgradable contract, so we'll have to check if these deployment scripts require change.

@snissn
Copy link
Contributor

snissn commented Apr 23, 2024

@raulk I have been working on changes here to support the upgrade semantics - #854 the process is a bit frustrating because of the slow timeline to run each test and I think the set up is flaky if multiple tests run concurrently

@maciejwitowski
Copy link
Contributor

Closing based on @snissn answer here #854 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants