-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorflow v2.13.0 #329
tensorflow v2.13.0 #329
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Are there any news on this? |
We just got 2.12.1 out the door. Feel free to open a PR to get things building at least until the timeout. |
Also adding a relevant quote from #324:
|
…nda-forge-pinning 2023.07.21.17.52.19
* dependency on jax got removed in 2.13 * keras-processing hasn't been a requirement since 2.11 * update protobuf constraint
landed right after 2.13.0 got released
…nda-forge-pinning 2023.07.28.09.35.51
7faeadc
to
ac6e5e0
Compare
Waiting for conda-forge/keras-feedstock#67 |
OK, this is downloading a specific commit of https://github.com/pybind/pybind11_protobuf, and then failing because it cannot find In the meantime, pybind11_protobuf has been updated to replace that line: "@com_google_absl//absl/strings",
"@com_google_absl//absl/types:optional",
- "@com_google_protobuf//:proto_api",
"@com_google_protobuf//:protobuf",
+ "@com_google_protobuf//python:proto_api",
],
) Notably, this doesn't just happen with newer protobuf, but also with 3.21. Not sure how upstream tensorflow builds 2.13, but I'm surprised they're not running into the same error? |
It seems that linux + CPU is going well. trying CUDA 11.2. I noticed that CUDA 12.0 migration was added. it couldn't find |
Linux + CPU passes locally. CUDA 12 needs adjustments similar to https://github.com/conda-forge/jaxlib-feedstock/pull/189/files Sadly, they don't seem to suffice as |
Cuda 11.2 is presently failing with:
|
If it's too much work we can drop it for now. I just tried to get all the big ticket items on the table. |
…nda-forge-pinning 2023.09.19.00.40.39
Could we bump CUDA from 11.2 to 11.8 in this PR? See conda-forge/conda-forge-pinning-feedstock#4834 and conda-forge/conda-forge.github.io#1981. Per https://conda-forge.org/status/, only jaxlib blocks the migration, but we have removed it in this PR. |
i guess from everybody, before requesting "extra migrations" please bear in mind that even in their absence, this is still problematic to build. nobody has confirmed if the linux + cuda builds are successful which are pretty critical to many of the tensorflow feedstock maintainers. |
They don't work but error with some protobuf issues locally in a kernel. I'm rerunning with a more clean workspace and can post them here if they persist. |
Even with a clean checkout, I get the following build errors for CUDA 11.2:
|
Seems like we are not the only ones with the same issue: https://stackoverflow.com/questions/76728242/compiling-cuda-files-that-rely-on-a-protobuf-message-with-a-map-field-results-in |
…nda-forge-pinning 2023.09.25.12.55.07
Same issue with CUDA 11.8. The offending code is the following:
|
Problems persist with libprotobuf 4.23.4 |
New protobuf, new error:
|
I don't even know which code causes this include 🤷 |
Why is the symbol |
That's just how abseil versions its symbols; abseil is generally highly backwards compatible, so using a newer version is normally never an issue.
If by "we" you mean the current state of the feedstock, then that's correct. I presume @xhochy has been building locally with the newer protobuf migrations, which are linked to newer abseil. |
Got it. But in #335, |
Generally things are pretty compatible, but the issue is that we cannot migrate for all combinations, so we only have the following in conda-forge:
More details
This shouldn't happen. It's more likely AFAICT that @xhochy hasn't pushed all updates to #335 yet. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5628359937, please use this URL for debugging.