Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.13.1 with old pinnings #344

Merged
merged 29 commits into from
Oct 23, 2023
Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Oct 14, 2023

Let's at least get this release out. We'll probably have to wait 1-2 more releases until we can loosen the protobuf pin.

Fixes #345
Fixes #329
(doesn't fix 335)

regro-cf-autotick-bot and others added 27 commits July 28, 2023 22:39
* dependency on jax got removed in 2.13
* keras-processing hasn't been a requirement since 2.11
* update protobuf constraint
landed right after 2.13.0 got released
Co-authored-by: Mark Harfouche <[email protected]>
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/build.sh Outdated Show resolved Hide resolved
@xhochy
Copy link
Member Author

xhochy commented Oct 14, 2023

This builds locally for me on Linux in the CPU-only and the CUDA 11.8 version. If someone can tell me what the correct configuration for CUDA 11.8 is, I can build and upload the full matrix.

@xhochy
Copy link
Member Author

xhochy commented Oct 23, 2023

Packages are ready. Linux packages are on uwe.korn-tf-gpu and macOS Packages on uwe.korn-tf-experimental. Logs:

@xhochy
Copy link
Member Author

xhochy commented Oct 23, 2023

@h-vetinari @hmaarrfk Can you copy and merge?

@h-vetinari
Copy link
Member

@h-vetinari @hmaarrfk Can you copy and merge?

Never copied artefacts yet, so I'll defer to @hmaarrfk.

@xhochy
Copy link
Member Author

xhochy commented Oct 23, 2023

The copy command is listed here: https://github.com/conda-forge/cfep/blob/main/cfep-03.md#specification I would also do this but I don't know whether that is OK according to the CFEP.

@hmaarrfk
Copy link
Contributor

you can also upload directly.

my instructions are in a comment #291

many thanks

@hmaarrfk hmaarrfk merged commit 96c00ed into conda-forge:main Oct 23, 2023
@hmaarrfk
Copy link
Contributor

@xhochy I feel like a while back we discussed that given the amount of core devs that were watching this package, it would be OK for them to directly upload.

Its pretty hard to store this many packages (even locally) so sometimes it has been prohibitive for me to keep creating random anaconda accounts.

@jonas-eschle
Copy link

Amazing, thanks a lot for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants