Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable pointerEvents during swiping #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enable pointerEvents during swiping #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ function SwipeableItem<T>(
});

function onAnimationEnd(openDirection: OpenDirection, snapPoint: number) {
setOpenDirection(openDirection);
onChange({ open: openDirection, snapPoint });
}

Expand Down Expand Up @@ -311,6 +310,7 @@ function SwipeableItem<T>(
: closestSnapPoint > 0
? OpenDirection.RIGHT
: OpenDirection.LEFT;
runOnJS(setOpenDirection)(openDirection)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange that this fixes the issue, any idea why?
I would expect this to be exactly the same as calling setOpenDirection on the first line in onAnimationEnd

What about all the other cases that onAnimationEnd is called? Wouldn't removing setOpenDirection cause incorrect state in those cases?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue are seeing is that the underlay is not intractable until after the animation is finished so if the user tries to press a button in the underlay while animation is "easing out" it wont work because pointer events are disabled here and this value isn't updated until the animation is completely finished. So the fix here is the underlay being intractable when the animation starts and this accomplishes that by setting the open direction sooner than it did before. I'm not sure about downstream issues from this but wanted to chime in with context as to what this is solving / why it solves.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try 2.0.8 and see if it fixes this issue?

runOnJS(onAnimationEnd)(openDirection, Math.abs(closestSnapPoint));
};
if (animStatePos.value === closestSnapPoint) onComplete();
Expand Down