doc: add instruction & feat: JEC/jetveto from jsonpog

[Ming-Yan]

add documentation for commissioning

[philippgadow]

This should only run for MC (I think):

Suggested change

	nocorrjet["Genpt"] = events.GenJet[nocorrjet.genJetIdx].pt
	if "GenJet" in events.fields: nocorrjet["Genpt"] = events.GenJet[nocorrjet.genJetIdx].pt

[philippgadow]

(maybe I was wrong here, but I got a mistake when running this PR on Summer22 data): AttributeError: no field named 'GenJet'

[Ming-Yan]

Hi @philippgadow thanks for the suggestion, you are right, I need to fix this :p I was only test on MC and this does not show error messages

[philippgadow]

also I saw the BTA producer workflows giving an error (also in the CI):

File "/home/runner/work/BTVNanoCommissioning/BTVNanoCommissioning/src/BTVNanoCommissioning/utils/correction.py", line 825, in JME_shifts
    if "Summer22" in campaign:
TypeError: argument of type 'bool' is not iterable

I fixed it locally with if "Summer22" in str(campaign):

[Ming-Yan]

also I saw the BTA producer workflows giving an error (also in the CI):

File "/home/runner/work/BTVNanoCommissioning/BTVNanoCommissioning/src/BTVNanoCommissioning/utils/correction.py", line 825, in JME_shifts
    if "Summer22" in campaign:
TypeError: argument of type 'bool' is not iterable

I fixed it locally with if "Summer22" in str(campaign):

Hi @philippgadow indeed this is because introduce the year in the correction configuration, to fix it, we need to change the JME_shifts

@@ -73,7 +73,14 @@ class NanoProcessor(processor.ProcessorABC):
 
         if "JME" in self.SF_map.keys() or "jetveto" in self.SF_map.keys():
             shifts = JME_shifts(
-                shifts, self.SF_map, events, self._campaign, isRealData, False, True
+                shifts,
+                self.SF_map,
+                events,
+                self._year,
+                self._campaign,
+                isRealData,
+                False,
+                True,
             )

[philippgadow]

Suggested change

	require=True,
	required=True,

[philippgadow]

Hi @philippgadow indeed this is because introduce the year in the correction configuration, to fix it, we need to change the JME_shifts

@@ -73,7 +73,14 @@ class NanoProcessor(processor.ProcessorABC):
 
         if "JME" in self.SF_map.keys() or "jetveto" in self.SF_map.keys():
             shifts = JME_shifts(
-                shifts, self.SF_map, events, self._campaign, isRealData, False, True
+                shifts,
+                self.SF_map,
+                events,
+                self._year,
+                self._campaign,
+                isRealData,
+                False,
+                True,
             )

Thanks :) - I just realised that I wasn't really fixing the issue and have modified the workflow, it's running now.