-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix small bug in --isArray mode #110
Conversation
Hi @mondalspandan thanks for adding the info back, indeed we now try to include the option where the jetveto map should obtained by jsonpog integration. this is in #106. Please let me know if things are good to merge |
Hi @mondalspandan , the jet veto maps root files have copied the html content. wget https://github.com/cms-jet/JECDatabase/raw/refs/heads/master/jet_veto_maps/Summer22_23Sep2023/Summer22_23Sep2023_RunCD_v1.root
wget https://github.com/cms-jet/JECDatabase/raw/refs/heads/master/jet_veto_maps/Summer22EE_23Sep2023/Summer22EE_23Sep2023_RunEFG_v1.root |
Hi @Ming-Yan, does this mean the relevant vetomap is automatically mapped in #106? |
Thanks a lot for spotting this! I copied and did not check if they worked, unfortunately. I have updated the PR. |
Hi @mondalspandan yes, right now it should directly take from the files in jsonpog-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, thanks!
No description provided.