Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small bug in --isArray mode #110

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

mondalspandan
Copy link
Contributor

No description provided.

@Ming-Yan
Copy link
Collaborator

Ming-Yan commented Jan 20, 2025

Hi @mondalspandan thanks for adding the info back, indeed we now try to include the option where the jetveto map should obtained by jsonpog integration. this is in #106. Please let me know if things are good to merge

@philippgadow
Copy link
Contributor

Hi @mondalspandan , the jet veto maps root files have copied the html content.
I tested locally and replaced them with

wget https://github.com/cms-jet/JECDatabase/raw/refs/heads/master/jet_veto_maps/Summer22_23Sep2023/Summer22_23Sep2023_RunCD_v1.root
wget https://github.com/cms-jet/JECDatabase/raw/refs/heads/master/jet_veto_maps/Summer22EE_23Sep2023/Summer22EE_23Sep2023_RunEFG_v1.root

@mondalspandan
Copy link
Contributor Author

Hi @mondalspandan thanks for adding the info back, indeed we now try to include the option where the jetveto map should obtained by jsonpog integration. this is in #106. Please let me know if things are good to merge

Hi @Ming-Yan, does this mean the relevant vetomap is automatically mapped in #106?

@mondalspandan
Copy link
Contributor Author

Hi @mondalspandan , the jet veto maps root files have copied the html content. I tested locally and replaced them with

wget https://github.com/cms-jet/JECDatabase/raw/refs/heads/master/jet_veto_maps/Summer22_23Sep2023/Summer22_23Sep2023_RunCD_v1.root
wget https://github.com/cms-jet/JECDatabase/raw/refs/heads/master/jet_veto_maps/Summer22EE_23Sep2023/Summer22EE_23Sep2023_RunEFG_v1.root

Thanks a lot for spotting this! I copied and did not check if they worked, unfortunately. I have updated the PR.

@Ming-Yan
Copy link
Collaborator

Hi @mondalspandan thanks for adding the info back, indeed we now try to include the option where the jetveto map should obtained by jsonpog integration. this is in #106. Please let me know if things are good to merge

Hi @Ming-Yan, does this mean the relevant vetomap is automatically mapped in #106?

Hi @mondalspandan yes, right now it should directly take from the files in jsonpog-integration

Copy link
Collaborator

@Ming-Yan Ming-Yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks!

@Ming-Yan Ming-Yan merged commit 1725016 into cms-btv-pog:master Jan 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants