Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pshtt scans failed this weekend #67

Closed
jsf9k opened this issue Dec 4, 2022 · 1 comment · Fixed by cisagov/pshtt#232
Closed

pshtt scans failed this weekend #67

jsf9k opened this issue Dec 4, 2022 · 1 comment · Fixed by cisagov/pshtt#232
Assignees
Labels
bug This issue or pull request addresses broken functionality

Comments

@jsf9k
Copy link
Member

jsf9k commented Dec 4, 2022

🐛 Summary

The pshtt scans did not take place this weekend.

To reproduce

  1. Attempt to run a full BOD 18-01 scan.
  2. Note that no pshtt AWS Lambdas are actually launched.

Expected behavior

The pshtt scans should complete without issue, as they have since time immemorial.

Any helpful log output or screenshots

Here is the error I am seeing in the Docker logs of the scanner container:

[pshtt] Downloading third party data...

-------------------------

Fetching Chrome preload list from source...

Starting new HTTPS connection (1): chromium.googlesource.com:443
https://chromium.googlesource.com:443 "GET /chromium/src/net/+/master/http/transport_security_state_static.json?format=TEXT HTTP/1.1" 404 None
Traceback (most recent call last):
  File "/home/scanner/domain-scan/scan", line 622, in <module>
    run(options, unknown, cache_dir, results_dir)
  File "/home/scanner/domain-scan/scan", line 122, in run
    scan_domains(scans, domains, options)
  File "/home/scanner/domain-scan/scan", line 171, in scan_domains
    init = scanner.init(environment, options)  # type: ignore
  File "/home/scanner/domain-scan/scanners/pshtt.py", line 41, in init
    'preload_list': pshtt.load_preload_list(),
  File "/usr/local/lib/python3.6/site-packages/pshtt/pshtt.py", line 1485, in load_preload_list
    raw = base64.b64decode(raw).decode('utf-8')
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 1: invalid continuation byte
@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Dec 4, 2022
@jsf9k jsf9k self-assigned this Dec 4, 2022
@jsf9k jsf9k added this to CyHy System Dec 4, 2022
@jsf9k jsf9k pinned this issue Dec 4, 2022
@jsf9k
Copy link
Member Author

jsf9k commented Dec 4, 2022

Looks like the issue is simply that this URL has changed. This is the new URL.

@jsf9k jsf9k moved this to In Progress in CyHy System Dec 4, 2022
Repository owner moved this from In Progress to Done in CyHy System Dec 5, 2022
@mcdonnnj mcdonnnj moved this to Done in BOD 18-01 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant