Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest release of pshtt #48

Merged
merged 10 commits into from
Dec 5, 2022
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 5, 2022

🗣 Description

This pull request updates the code to:

  • Use the Python 3.7 AWS Lambda runtime
  • Install/upgrade wheel at the same time as pip and setuptools
  • Use the latest release of cisagov/pshtt

💭 Motivation and context

  • The Python 3.6 runtime is no longer supported by AWS Lambda.
  • The wheel package is preferred to setuptools for many packages.
  • The latest release of cisagov/pshtt fixes a bug.

🧪 Testing

I successfully used these changes to deploy an updated pshtt Lambda. The TravisCI builds are failing because we no longer use TravisCI.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Python 3.6 is no longer supported by AWS.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality improvement This issue or pull request will add new or improve existing functionality version bump This issue or pull request increments the version number labels Dec 5, 2022
@jsf9k jsf9k self-assigned this Dec 5, 2022
@jsf9k jsf9k force-pushed the improvement/update-for-python-3.7 branch from 8f771a4 to a7be011 Compare December 5, 2022 15:20
README.md Outdated Show resolved Hide resolved
pshtt/Dockerfile Show resolved Hide resolved
pshtt/build_pshtt.sh Outdated Show resolved Hide resolved
@jsf9k jsf9k force-pushed the improvement/update-for-python-3.7 branch from 967b979 to 66c1cfd Compare December 5, 2022 15:48
@jsf9k jsf9k requested a review from mcdonnnj December 5, 2022 15:52
@jsf9k jsf9k marked this pull request as ready for review December 5, 2022 16:27
@jsf9k jsf9k requested review from dav3r and felddy December 5, 2022 16:34
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough. I had one question and then I'm not sure if you feel like dealing with it right now but it'd be nice if long command line options were used throughout the Dockerfiles/build scripts.

pshtt/build_pshtt.sh Show resolved Hide resolved
@jsf9k
Copy link
Member Author

jsf9k commented Dec 5, 2022

it'd be nice if long command line options were used throughout the Dockerfiles/build scripts

Given that the long-term plan is to move this jazz to the new skeleton you created, I don't want to invest that effort right now. You can create an issue if you want to.

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@jsf9k jsf9k merged commit f293cfe into develop Dec 5, 2022
@jsf9k jsf9k deleted the improvement/update-for-python-3.7 branch December 5, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality improvement This issue or pull request will add new or improve existing functionality version bump This issue or pull request increments the version number
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants