-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest release of pshtt #48
Conversation
Python 3.6 is no longer supported by AWS.
8f771a4
to
a7be011
Compare
Co-authored-by: Nick <[email protected]>
18F/domain-scan has been archived, so the only way to update it to create Python 3.7 lambdas was to fork the repo.
Co-authored-by: Nick <[email protected]>
967b979
to
66c1cfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable enough. I had one question and then I'm not sure if you feel like dealing with it right now but it'd be nice if long command line options were used throughout the Dockerfiles/build scripts.
Given that the long-term plan is to move this jazz to the new skeleton you created, I don't want to invest that effort right now. You can create an issue if you want to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
🗣 Description
This pull request updates the code to:
wheel
at the same time aspip
andsetuptools
💭 Motivation and context
wheel
package is preferred tosetuptools
for many packages.🧪 Testing
I successfully used these changes to deploy an updated
pshtt
Lambda. The TravisCI builds are failing because we no longer use TravisCI.✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist