-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken preload URL #232
Conversation
The location of this data has been updated upstream.
Can we just drop support for Python 3.6? The 3.6 tests are failing because GitHub Actions no longer supports 3.6. I can just ignore them for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will drop Python 3.6 support when we update to a newer version of sslyze so I'd rather just leave that alone for now. Do you want to handle the release to PyPI or shall I?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Nick <[email protected]>
🗣 Description
This pull request fixes a broken URL pointing to the Chromium HSTS preloaded domain list.
💭 Motivation and context
The location of this data has changed upstream, and this is breaking the BOD 18-01 scanning.
Required to resolve cisagov/scanner#67.
🧪 Testing
All automated testing that is expected to pass passes. The Python 3.6 tests fail because Python 3.6 is no longer supported by GitHub Actions.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist