-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all rego #141
Refactor all rego #141
Conversation
Sorry for creating a new PR. I renamed the branch without realizing that would cause the PR to close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
Co-authored-by: David Bui <[email protected]>
Co-authored-by: David Bui <[email protected]>
Co-authored-by: David Bui <[email protected]>
Co-authored-by: David Bui <[email protected]>
Co-authored-by: David Bui <[email protected]>
Co-authored-by: David Bui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests and smoke testing passed. Good to go.
🗣 Description
💭 Motivation and context
Closes #117.
Closes #69.
🧪 Testing
Tests I performed:
.\regal.exe lint --format github rego Testing
passes (using the config file in the .regal folder).\opa_windows_amd64.exe check --rego-v1 rego Testing
passes✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist