Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes DRIVE_DOCS.2.1v0.1 from Baseline per Issue 127 #130

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

jkaufman-mitre
Copy link
Collaborator

This pr removes policy 2.1 from the Drive_Docs baseline due to the policy not being security relevant.

Fixes #129

Copy link
Contributor

@LaurenBassett LaurenBassett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Are we renumbering issues 2.2-2.5?
  2. The tests need to be updated.

Copy link
Collaborator

@tmcomeau tmcomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will re-review once the re-numbering is complete and the tests are added. @LaurenBassett will you make a separate issue and another PR for that?

@jkaufman-mitre jkaufman-mitre requested a review from adhilto January 5, 2024 17:33
@jkaufman-mitre
Copy link
Collaborator Author

Re-numbered Policy group 2 policies. Also, fixed the drift rules file.

@jkaufman-mitre jkaufman-mitre changed the title Addresses issue in issue 129 Removes DRIVE_DOCS.2.1v0.1 from Baseline per Issue 127 Jan 8, 2024
@adhilto adhilto added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jan 8, 2024
@adhilto
Copy link
Collaborator

adhilto commented Jan 8, 2024

Marking as blocked due to the needed Rego changes. Once #141 is merged in, I will un-block and update make the corresponding Rego updates.

@adhilto adhilto removed the request for review from buidav January 9, 2024 00:26
@adhilto adhilto changed the base branch from main to 124-feedback-no-guifront-end-availability-solution January 16, 2024 01:13
@adhilto adhilto changed the base branch from 124-feedback-no-guifront-end-availability-solution to main January 16, 2024 01:13
@adhilto adhilto removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jan 16, 2024
@adhilto
Copy link
Collaborator

adhilto commented Jan 16, 2024

@LaurenBassett I just made the needed Rego changes. Could you review?

@adhilto adhilto merged commit be35ce3 into main Jan 16, 2024
3 checks passed
@adhilto adhilto deleted the drive-docs-snl-changes-2 branch January 16, 2024 18:39
@adhilto adhilto added this to the TBD 0.2 Milestone milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Policy 2.1 from Drive_Docs
4 participants