Moved Wording from MEET3.1v0.1 Policy Statement to Rationale #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcomeau
reviewed
Jan 3, 2024
baselines/Google Meet Minimum Viable Secure Configuration Baseline v0.1.md
Outdated
Show resolved
Hide resolved
tmcomeau
approved these changes
Jan 3, 2024
…line v0.1.md Co-authored-by: Thomas Comeau (MITRE) <[email protected]>
|
@LaurenBassett Feel free to review. We can merge once we have concurrence from you and @buidav. |
buidav
requested changes
Jan 8, 2024
There was a problem hiding this comment.
These request changes apply for Pull Requests #127, #128, #130, #133, #138, #140 as well.
- Follow the PR template directions for adding description, linking and closing issues etc. Adding in and filling out the PR template greatly helps the going back to read PRs in the future. Also, helps reviewers know what they are reviewing without having to dig too much for context. https://github.com/cisagov/ScubaGoggles/blob/main/.github/pull_request_template.md
- That goes for the titles as well.
Made the changes for issue 125, 126,etc. are not informative titles. This hampers generating automatically generating release notes in the future. When auto generating the release notes GitHub pull takes directly from the Pull Request titles. First checkbox of the PR template.This PR has an informative and human-readable title.https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
jkaufman-mitre
changed the title
adhilto
approved these changes
Jan 8, 2024
LaurenBassett
approved these changes
Jan 10, 2024
buidav
approved these changes
Jan 11, 2024
baselines/Google Meet Minimum Viable Secure Configuration Baseline v0.1.md
Outdated
Show resolved
Hide resolved
… Configuration Baseline v0.1.md Co-authored-by: David Bui <[email protected]>
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Moved "so that they are available by default when a host starts their meeting." from the MEET.3.1v0.1 policy statement to the rationale section in order to keep the policy statement concise.
Fixes #125