bpf_metadata: cleanup case for N/S L7 LB #1072
Merged
+28
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit combines the nested conditions in the method `getPolicy` that are handling the special case for N/S L7 Loadbalancing. (Allow all traffic if no explicit Ingress policy is set) Signed-off-by: Marco Hofstetter <[email protected]>
sayboras
approved these changes
Dec 31, 2024
jrajahalme
requested changes
Jan 7, 2025
mhofstetter
force-pushed
the
pr/mhofstetter/bpfmetadata-clarify-ns-l7lb
branch
from
8cdf1b4 to
0021cc7
Compare
jrajahalme
requested changes
Jan 7, 2025
This commit simplifies the variable naming for the N/S L7 LB case in getMetadata. * Rename `ip` to `ingress_ip` * use `ingress_ip` instead of `pod_ip` to avoid confusion Signed-off-by: Marco Hofstetter <[email protected]>
This commit removes an outdated comment about Ingress IP handling.
Currently, the existence of an Ingress source IP with the right IP
family is validated in the config.
See
```
const Network::Address::Ip* ingress_ip = selectIPVersion(sip->version(), source_addresses);
if (!ingress_ip) {
// IP family of the connection has no configured local ingress source address
ENVOY_LOG(
warn,
"cilium.bpf_metadata (north/south L7 LB): No local Ingress IP source address configured "
"for the family of {}",
sip->addressAsString());
return nullptr;
}
```
Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
force-pushed
the
pr/mhofstetter/bpfmetadata-clarify-ns-l7lb
branch
from
0021cc7 to
2c4e3c7
Compare
jrajahalme
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits