Skip to content

Commit

Permalink
bpf_metadata: remove outdated comment
Browse files Browse the repository at this point in the history
This commit removes an outdated comment about Ingress IP handling.

Currently, the existence of an Ingress source IP with the right IP
family is validated in the config.

See

```
    const Network::Address::Ip* ingress_ip = selectIPVersion(sip->version(), source_addresses);

    if (!ingress_ip) {
      // IP family of the connection has no configured local ingress source address
      ENVOY_LOG(
          warn,
          "cilium.bpf_metadata (north/south L7 LB): No local Ingress IP source address configured "
          "for the family of {}",
          sip->addressAsString());
      return nullptr;
    }
```

Signed-off-by: Marco Hofstetter <[email protected]>
  • Loading branch information
mhofstetter committed Jan 7, 2025
1 parent 16b2bd1 commit 0021cc7
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions cilium/bpf_metadata.cc
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,6 @@ Cilium::SocketOptionSharedPtr Config::getMetadata(Network::ConnectionSocket& soc
pod_ip = ingress_ip_str;

// Original source address is never used for north/south LB
// This means that a local host IP is used if no IP is configured to be used instead of it
// ('ip' above is null).
src_address = nullptr;
} else if (!use_original_source_address_ || (npmap_ != nullptr && npmap_->exists(other_ip))) {
// Otherwise only use the original source address if permitted and the destination is not
Expand Down

0 comments on commit 0021cc7

Please sign in to comment.