add level column to audits #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Will break old surveys using audits. |
Why, which "old surveys"? The pre-audits v2, or break actual v2? |
tahini
requested changes
Feb 5, 2024
|
|
||
| export async function up(knex: Knex): Promise<unknown> { | ||
| return knex.schema.alterTable(tableName, (table: Knex.TableBuilder) => { | ||
| table.enu(columnName, ['error', 'warning', 'info']).defaultTo('error').notNullable().index(); |
There was a problem hiding this comment.
Before dropping the is_warning column, you should set the level column to 'warning' if is_warning is true
There was a problem hiding this comment.
Not needed since only one survey uses audits v2 (od_mtl_2023) and audits needs to be reset anyway since they are not yet complete.
| ignore: true, | ||
| objectType: 'interview', | ||
| objectUuid: arbitraryUuid | ||
| }, { | ||
| version: 1, | ||
| errorCode: 'test-error-2', | ||
| message: 'Test error message', | ||
| isWarning: false, | ||
| level: 'error' as ('error' | 'warning' | 'info' | undefined), |
There was a problem hiding this comment.
simply as const will compile properly, no need to cast to the whole enum
kaligrafy
force-pushed
the
addLevelToAuditTable
branch
from
309a367 to
e16ed06
Compare
tahini
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.