add isInfo to audits #370
add isInfo to audits #370
Conversation
There was a problem hiding this comment.
info/warning looks like a log's level concept. We should rather have a level field, with an enum or number to identify an audit level. The number allows to have a hierarchy of the levels. Otherwise, we can have an audit that can be both info and warning and that is not conceptually right.
|
|
||
| export async function up(knex: Knex): Promise<unknown> { | ||
| return knex.schema.alterTable(tableName, (table: Knex.TableBuilder) => { | ||
| table.boolean('is_info'); |
There was a problem hiding this comment.
Can an audit be both info and warning? Usually, concepts like that will use a level field: error, warning, info (critical, debug, trace, but we don't need those for audits I suppose)
There was a problem hiding this comment.
Merging warning and error into a level would mean long refactoring. Let's keep as is for now, and add an issue for later?
There was a problem hiding this comment.
So we replace is_warning and is_info with level and we put default to error?
|
Replaced by #372 |
No description provided.