Output diagnostic information about core sizes #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary 4 478 files 6 904 suites 15m 26s ⏱️ Results for commit c17d71d. ♻️ This comment has been updated with latest results. |
amandalund
approved these changes
Jan 24, 2025
sethrj
added a commit
that referenced
this pull request
Jan 27, 2025
* Add an optional parameter for setting state size via params * Write out core sizes to JSON * Add and fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the mess in #1577 and discussions in #1562 , we really need a definitive diagnostic about the state sizes.
The gotcha is that the number of states isn't previously known to the core params (it's passed on constructing the stepper or core state). With #1556 we want to transition to more tightly integrating the params and state, so for now I'm adding an optional "state size" to the params that can be used to create the core state. For now this state size is set by the apps (where we care about the diagnostic) but not the unit tests (which often reuse the same core params with different stepper sizes).